Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EPERM into EACCES for file access #911

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Sep 14, 2021

Landlock returns this, not EPERM.

Landlock returns this, not EPERM.
@dmoj-build
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

Codecov Report

Merging #911 (9f119dd) into master (0879113) will decrease coverage by 0.38%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
- Coverage   86.27%   85.88%   -0.39%     
==========================================
  Files         137      137              
  Lines        4640     4640              
==========================================
- Hits         4003     3985      -18     
- Misses        637      655      +18     
Impacted Files Coverage Δ
dmoj/cptbox/isolate.py 91.45% <66.66%> (-4.28%) ⬇️
dmoj/utils/communicate.py 88.15% <0.00%> (-5.27%) ⬇️
dmoj/executors/mixins.py 91.48% <0.00%> (-3.20%) ⬇️
dmoj/executors/java_executor.py 85.49% <0.00%> (-2.08%) ⬇️
dmoj/cptbox/tracer.py 81.45% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0879113...9f119dd. Read the comment docs.

@kiritofeng
Copy link
Member

ok to test

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xyene Xyene merged commit 60f1db5 into DMOJ:master Sep 15, 2021
@Riolku Riolku deleted the eaccess branch September 15, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants